SEC-1714: RegexRequestMatcher's matches should append question mark after path info and before query #1950

Closed
spring-issuemaster opened this Issue Apr 10, 2011 · 1 comment

1 participant

@spring-issuemaster

Stevo Slavić (Migrated from SEC-1714) said:

        if (pathInfo != null || query != null) {
            StringBuilder sb = new StringBuilder(url);

            if (pathInfo != null) {
                sb.append(pathInfo);
            }

            if (query != null) {
                sb.append(query);
            }
            url = sb.toString();
        }

should be replaced with something similar to

        if (pathInfo != null || query != null) {
            StringBuilder sb = new StringBuilder(url);

            if (pathInfo != null) {
                sb.append(pathInfo);
            }

            if (query != null) {
                sb.append("?").append(query);
            }
            url = sb.toString();
        }
@spring-issuemaster

Luke Taylor said:

Good point. I've change the code to append the question mark when there's a query string.

@spring-issuemaster spring-issuemaster added this to the 3.1.0.RC2 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment