Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1737: Provide JPA-based UserDetailsService & UserDetailsManager abstract implementations #1973

Closed
spring-projects-issues opened this issue May 10, 2011 · 2 comments
Assignees
Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement type: jira An issue that was migrated from JIRA

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented May 10, 2011

Matthew T. Adams (Migrated from SEC-1737) said:

Sometimes it's handy to have a JPA-based UserDetailsService or UserDetailsManager instead of a JDBC-based one. The attached classes are abstract classes that do the boilerplate work of the UserDetailsService & UserDetailsManager implementation, defining abstract methods for subclasses to implement for the user's specific entities that represent users & groups.

Contributing since I considered it helpful, and I figured others might like to have it. It does introduce a dependency on JPA, so should probably go into some kind of separate contrib module outside of core.

Hope you likey.

@spring-projects-issues
Copy link
Author

spring-projects-issues commented May 10, 2011

Matthew T. Adams said:

Just noticed JpaUserDetailsManager.java should probably be in the package org.springframework.security.provisioning to align with JdbcUserDetailsManager.

@spring-projects-issues spring-projects-issues added in: core An issue in spring-security-core Open type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@rwinch rwinch added type: enhancement A general enhancement and removed Open labels May 3, 2019
@rwinch rwinch added the status: declined A suggestion or change that we don't feel we should currently apply label May 25, 2021
@rwinch
Copy link
Member

rwinch commented May 25, 2021

Thank you for the report. We are not going to provide additional implementations of UserDetaisService as it will get difficult to maintain. Additionally, we are unlikely to provide all the attributes users want, so they will likely need to provide their own. Finally, it is easy enough for user's to provide their own implementation. For these reasons, I'm closing this as declined.

@rwinch rwinch closed this as completed May 25, 2021
@rwinch rwinch self-assigned this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

2 participants