SEC-1903: FirewalledResponse recompiles constant regex pattern for every instance #2134

Closed
spring-issuemaster opened this Issue Jan 31, 2012 · 1 comment

1 participant

@spring-issuemaster

Ophir Radnitz (Migrated from SEC-1903) said:

org.springframework.security.web.firewal.FirewalledResponse holds a regex Pattern as an instance member. This means it is instantiated and recompiled for every FirewalledResponse instance. These are created quite rapidly in the FilterChainProxy filter invocation. The pattern should probably become a static member.

@spring-issuemaster

Rob Winch said:

Assigning to Luke since he has already pushed a fix out

@spring-issuemaster spring-issuemaster added this to the 3.1.1 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment