SEC-1988: Create Contributors Guide #2212

Closed
spring-issuemaster opened this Issue Jun 30, 2012 · 4 comments

2 participants

@spring-issuemaster

Rob Winch (Migrated from SEC-1988) said:

Currently there is no documentation on contributing. As the current process for Spring Security differs from Spring Framework we should either find some consistency or provide our own documentation.

@spring-issuemaster

stanislav bashkirtsev said:

Could you post a comment saying where we can find the updates?

@spring-issuemaster

Rob Winch said:

Sure thing. There is a link pointing to the Contributor Guidelines in the readme.txt of the project which can be seen from the main Spring Security github page.

PS: Thanks for pointing out that I did not add a link on the JIRA. This will likely help others that stumble on this JIRA too.

@spring-issuemaster

stanislav bashkirtsev said:

Thanks for the link! One question though - what about Pull Requests that were done before this guide was created? I have one =)

@spring-issuemaster

Rob Winch said:

You should update the pull request. I'm fairly focused on bugs right now, but once I get the bugs under control I will be trying to prioritize pull requests that follow the guidelines well since this means the work is essentially done.

@spring-issuemaster spring-issuemaster added this to the 3.1.2 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment