New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1990: Code cleanup on bcrypt implementation #2214

Closed
spring-issuemaster opened this Issue Jul 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster

spring-issuemaster commented Jul 4, 2012

Joseph Walton (Migrated from SEC-1990) said:

I've cleaned the code up in the standalone jBCrypt project. This issue is to merge those changes into Spring Security along with its tests.

  • Use a ByteArrayOutputStream to cache bytes.
  • Pass a StringBuilder into encode_base64.
  • Refactor string comparison into its own method.
  • General clean up.
@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jul 4, 2012

@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jul 5, 2012

Rob Winch said:

Thanks you for your contribution. It has been merged into master and will be included in the 3.1.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment