Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SEC-1990: Code cleanup on bcrypt implementation #2214

spring-issuemaster opened this Issue Jul 4, 2012 · 2 comments


None yet
2 participants

Joseph Walton (Migrated from SEC-1990) said:

I've cleaned the code up in the standalone jBCrypt project. This issue is to merge those changes into Spring Security along with its tests.

  • Use a ByteArrayOutputStream to cache bytes.
  • Pass a StringBuilder into encode_base64.
  • Refactor string comparison into its own method.
  • General clean up.

Rob Winch said:

Thanks you for your contribution. It has been merged into master and will be included in the 3.1.1 release

@spring-issuemaster spring-issuemaster added this to the 3.1.1 milestone Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment