Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-2053: Spring Security does not allow configuring system exception that can occur during authentication #2277

Closed
spring-projects-issues opened this issue Sep 16, 2012 · 4 comments
Assignees
Labels
in: core in: web status: invalid type: enhancement type: jira

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 16, 2012

joseph antony aruja (Migrated from SEC-2053) said:

When implementing Custom Handlers for authentication failures, the application developer have to write extra code to handle various system exceptions that can occur during authentication.

Custom AuthenticationFailureHandlerImpl is attached. If this can be moved as a a part of annotation or configuration, it will really improve the framework

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 17, 2012

joseph antony aruja said:

The attached class is the one I implemented When I have to handle System exception during Authentication.

Any ideas / suggestion ?..

In the core framework exceptions can be handled in a more elegant way with writing code. So it would be better to incorporate a way to manage the exception than can occur during authentication

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 17, 2012

Rob Winch said:

ExceptionMappingAuthenticationFailureHandler should cover this use case already. If you disagree, can you please elaborate?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 17, 2012

joseph antony aruja said:

Thanks Rob. Not recently explored all the new classes. Looks like it can cover most of the exception mapping. Need to do some testing before I can comment further..

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 2, 2012

Rob Winch said:

Resolving per the suggestion above

@spring-projects-issues spring-projects-issues added in: core in: web Closed type: enhancement status: invalid type: jira labels Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core in: web status: invalid type: enhancement type: jira
Projects
None yet
Development

No branches or pull requests

2 participants