Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-2166: JdbcUserDetailsManager populates old password when changing a password #2392

Closed
spring-issuemaster opened this issue May 7, 2013 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link

@spring-issuemaster spring-issuemaster commented May 7, 2013

Rob Winch (Migrated from SEC-2166) said:

https://github.com/SpringSource/spring-security/blob/master/core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java#L220

the method createNewAuthentication takes a password argument (the new password) which it then ignores.

While this appears to be a bug, it should have a negligible impact on users in most cases since the password is not used once the user is authenticated. In fact, one could argue that since the namespace defaults to clearing out the credentials, we should not be populating the password at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.