Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-2833: Rossen's Feedback on WebSocket #3057

Closed
spring-projects-issues opened this issue Jan 29, 2015 · 0 comments
Closed

SEC-2833: Rossen's Feedback on WebSocket #3057

spring-projects-issues opened this issue Jan 29, 2015 · 0 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jan 29, 2015

Rob Winch (Migrated from SEC-2833) said:

  • simpDestMessageMatcher -> simpMessageDestMatcher
  • simpDestSubscribeMatcher -> simpSubscribeDestMatcher
  • AbstractSecurityWebSocketMessageBrokerConfigurer inboundRegistry should not be field. It may be possible configureClientInboundChannel is called first and the hasMapping could return false -> This is not possible because configureClientInboundChannel invokes inboundChannelSecurity() which invokes inboundMessageSecurityMetadataSource()
  • see AuthenticationPrincipalArgumentResolver on AuthenticationPrincipal should be fully qualified
  • AbstractSecurityWebSocketMessageBrokerConfigurer registerStompEndpoints should not be final
  • Above implies need method for configureClientInboundChannel to call to allow customizations by subclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants