Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-193: Duplicate code in SiteminderAuthenticationProcessingFilter #454

Closed
spring-issuemaster opened this issue Feb 19, 2006 · 4 comments
Closed

Comments

@spring-issuemaster
Copy link

@spring-issuemaster spring-issuemaster commented Feb 19, 2006

Luke Taylor(Migrated from SEC-193) said:

SiteminderAuthenticationProcessingFilter seems to have quite a few methods (getDefaultFilterProcessesUrl, setDetails, filter lifecycle methods) which are the same as those in its base class, AuthenticationProcessingFilter. They can probably be safely removed.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Apr 24, 2006

Ben Alex said:

Scott, could you please take a closer look and refactor as needed? Thanks.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Apr 24, 2006

Scott McCrory said:

OK, will do.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Apr 25, 2006

Scott McCrory said:

Changes committed to SVN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.