Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for nested builders in the DSL #5557

Closed
joshlong opened this issue Jul 22, 2018 · 6 comments

Comments

@joshlong
Copy link
Member

commented Jul 22, 2018

This could take advantage of lambdas in Java 8.

This would mean we could configure things in Spring Security without worrying about indents.

foo 
  .a ( aSpec  ->aSpec.foo() .bar()) 
  .b ( bSpec -> bSpec x().y())

Spring Integration and Spring Cloud Gateway both support similar nested builder style DSLs.

@eleftherias eleftherias self-assigned this May 14, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue May 23, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue May 23, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue May 23, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 4, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 17, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 18, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 18, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 18, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 19, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 19, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 20, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 20, 2019

rwinch added a commit that referenced this issue Jun 20, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 27, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 28, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 28, 2019

eleftherias added a commit to eleftherias/spring-security that referenced this issue Jun 28, 2019

@L00kian

This comment has been minimized.

Copy link

commented Jul 16, 2019

@philwebb @eleftherias is the same approach viable for webflux config classes? I didn't find an issue raised to that

@eleftherias

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@L00kian Thank you for mentioning webflux, I have created the issue for it here gh-7107.

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

ynojima added a commit to ynojima/spring-security that referenced this issue Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.