New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodSecurityEvaluationContext Should Check Parameter Names Are Not Null #6223

Open
rwinch opened this Issue Dec 4, 2018 · 10 comments

Comments

Projects
None yet
3 participants
@rwinch
Member

rwinch commented Dec 4, 2018

Summary

Spring Security's MethodSecurityEvaluationContext should ignore parameter names that are null.

Related: https://jira.spring.io/browse/SPR-17565

@shraiysh

This comment has been minimized.

Contributor

shraiysh commented Dec 5, 2018

Hi @rwinch, I would like to take this one.

@rwinch

This comment has been minimized.

Member

rwinch commented Dec 5, 2018

Thanks for the offer. I'd like to keep this for a first time contributor for the moment. If you are looking for more issues, please check out the help wanted and exclude the first timers only label. Here is the query if you need it https://github.com/spring-projects/spring-security/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22help+wanted%22+sort%3Aupdated-desc++-label%3Afirst-timers-only

@shabari004

This comment has been minimized.

shabari004 commented Dec 5, 2018

Hi can i work on this

@rwinch

This comment has been minimized.

Member

rwinch commented Dec 5, 2018

Thank you for volunteering to work on this @shabari004! The issue is yours. Please let me know if you need any help.

@shabari004

This comment has been minimized.

shabari004 commented Dec 5, 2018

@rwinch i dont see any test cases for this class, do we need any test cases for this

@shraiysh

This comment has been minimized.

Contributor

shraiysh commented Dec 6, 2018

Thanks @rwinch.

@rwinch

This comment has been minimized.

Member

rwinch commented Dec 6, 2018

@rwinch i dont see any test cases for this class, do we need any test cases for this

@shabari004 There are not currently unit tests as this is tested in other places. However, I think it would make sense for this scenario to create unit tests.

@shabari004

This comment has been minimized.

shabari004 commented Dec 6, 2018

@rwinch sorry to bother you, can i get some help in creating the test cases please.

@rwinch

This comment has been minimized.

Member

rwinch commented Dec 7, 2018

@shabari004 You may. What help do you need? Can you describe the problem you are having? Can you post a branch with the code you have?

@shabari004

This comment has been minimized.

shabari004 commented Dec 7, 2018

@rwinch Hi i created a pull request with my code. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment