Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-368: Spelling corrections in captcha apis and implementations #630

Closed
spring-issuemaster opened this issue Oct 3, 2006 · 5 comments
Closed

Comments

@spring-issuemaster
Copy link

@spring-issuemaster spring-issuemaster commented Oct 3, 2006

Denis McCarthy(Migrated from SEC-368) said:

e.g. in TestOnceAfterMaxRequestsCaptchaChannelProcessor, default keyword is REQUIRES_CAPTCHA_ONCE_ABOVE_THRESOLD_REQUESTS. In an ideal world his should be REQUIRES_CAPTCHA_ONCE_ABOVE_THRESHOLD_REQUESTS. I know this is a bit anal but who cares.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Nov 12, 2006

Ben Alex said:

This will require a non-backward-compatible change to support the correct spelling of the keyword. As it’s fairly minor in importance, I’ve slated it for 1.1.0.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Sep 10, 2007

Luke Taylor said:

There were quite a few instances of this throughout the captcha code. I’ve also changed method names in CaptchaSecurityContext (ressouces → resources) and the “getThresold” method of CaptchaChannelProcessorTemplate.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Sep 18, 2007

Luke Taylor said:

The changes have been made.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Mar 16, 2008

Luke Taylor said:

Missed some corrections.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Mar 19, 2008

Luke Taylor said:

I’ve made further changes o the captcha module, changing some of the constants. Also many of the comments which still contained references to invalid names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.