New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JwtTimestampValidator should change maxClockSkew to clockSkew #6380

Closed
jzheaux opened this Issue Jan 10, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@jzheaux
Copy link
Contributor

jzheaux commented Jan 10, 2019

JwtTimestampValidator has a property called maxClockSkew.

Let's simplify this to clockSkew. We need to change the field name, the constructor parameter, and the error message in the constructor.

ajavorskidev added a commit to ajavorskidev/spring-security that referenced this issue Jan 11, 2019

Update JwtTimestampValidator.java
Changed MaxClockSkew variable to clockSkew to simplify the name.

Fixes spring-projectsgh-6380
@darthCodr

This comment has been minimized.

Copy link
Contributor

darthCodr commented Jan 12, 2019

Hello, @jzheaux can I work on this issue?

jzheaux added a commit that referenced this issue Jan 14, 2019

Update JwtTimestampValidator.java
Changed MaxClockSkew variable to clockSkew to simplify the name.

Fixes gh-6380
@jzheaux

This comment has been minimized.

Copy link
Contributor

jzheaux commented Jan 14, 2019

@darthCodr Thanks for your interest, but this was picked up already by @ajavorskidev. My apologies for not noting that in the ticket earlier when the PR was submitted.

@darthCodr

This comment has been minimized.

Copy link
Contributor

darthCodr commented Jan 15, 2019

@jzheaux It's fine. I will wait for the next one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment