New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML Namespace Support #104

Open
rwinch opened this Issue Jan 14, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@rwinch
Member

rwinch commented Jan 14, 2015

We should support Spring XML Namespace configuration of Spring Session

NOTE: Update httpsesson-xml sample and guide (don't forget to remove link to this issue in guide)

Relates to #101

@rmkellogg

This comment has been minimized.

Show comment
Hide comment
@rmkellogg

rmkellogg Oct 24, 2016

If you provide an example of the XML I might be able to help.

rmkellogg commented Oct 24, 2016

If you provide an example of the XML I might be able to help.

@danekja

This comment has been minimized.

Show comment
Hide comment
@danekja

danekja Nov 11, 2016

Hi, I am also willing to help. We prefer XML configuration over Java in our projects and having to use Java configuration for Spring Session (with websockets) creates an inconsistence.

I suppose any of the existing parsers can be used for entry reference on how to implement it. The question is how should the namespace actually look. Are there any rules which would allow me/us to create a draft of the schema?

danekja commented Nov 11, 2016

Hi, I am also willing to help. We prefer XML configuration over Java in our projects and having to use Java configuration for Spring Session (with websockets) creates an inconsistence.

I suppose any of the existing parsers can be used for entry reference on how to implement it. The question is how should the namespace actually look. Are there any rules which would allow me/us to create a draft of the schema?

@rwinch

This comment has been minimized.

Show comment
Hide comment
@rwinch

rwinch Nov 11, 2016

Member

Thanks for the offers to help @rmkellogg and @danekja Please ensure to coordinate efforts via this issue to ensure there isn't overlap in your work.

I think what we would look for is something like this:

<session:redis max-inactive-interval-seconds="1800" 
                         redis-namespace="my-app" 
                         redis-flush-mode="ON_SAVE" />

Each of these attributes would be optional and reflect the options of @EnableRedisHttpSession

We would have similar namespaces for:

  • @EnableGemFireHttpSession
  • @Enable HazelcastHttpSession
  • @EnableJdbcHttpSession
  • @EnableMongoHttpSession
  • @EnableSpringHttpSession
Member

rwinch commented Nov 11, 2016

Thanks for the offers to help @rmkellogg and @danekja Please ensure to coordinate efforts via this issue to ensure there isn't overlap in your work.

I think what we would look for is something like this:

<session:redis max-inactive-interval-seconds="1800" 
                         redis-namespace="my-app" 
                         redis-flush-mode="ON_SAVE" />

Each of these attributes would be optional and reflect the options of @EnableRedisHttpSession

We would have similar namespaces for:

  • @EnableGemFireHttpSession
  • @Enable HazelcastHttpSession
  • @EnableJdbcHttpSession
  • @EnableMongoHttpSession
  • @EnableSpringHttpSession
@danekja

This comment has been minimized.

Show comment
Hide comment
@danekja

danekja Nov 11, 2016

Thanks, @rwinch, for getting back. Im gonna start working on the schema draft right away. Let's also use this comment as list of tasks that need to be done. Im going to keep it updated based on what we do here.

TODO

Schema Definitions

Parser Implementations

  • RedisHttpSession
  • GemFireHttpSession
  • JdbcHttpSession
  • MongoHttpSession
  • HazelcastHttpSession
  • SpringHttpSession
  • SpringHttpSession
  • WebSocketMessageBrokerConfigurer

Documentation

  • Create/Update Documentation

danekja commented Nov 11, 2016

Thanks, @rwinch, for getting back. Im gonna start working on the schema draft right away. Let's also use this comment as list of tasks that need to be done. Im going to keep it updated based on what we do here.

TODO

Schema Definitions

Parser Implementations

  • RedisHttpSession
  • GemFireHttpSession
  • JdbcHttpSession
  • MongoHttpSession
  • HazelcastHttpSession
  • SpringHttpSession
  • SpringHttpSession
  • WebSocketMessageBrokerConfigurer

Documentation

  • Create/Update Documentation
@danekja

This comment has been minimized.

Show comment
Hide comment
@danekja

danekja Nov 11, 2016

So, I have started works on the schema. @rwinch, what kind of process do you wish to have on checking the work? Are you going to check during the development to discover any possible misconceptions early, or do you want to see only the final result? I'm a bit new to this :)

danekja commented Nov 11, 2016

So, I have started works on the schema. @rwinch, what kind of process do you wish to have on checking the work? Are you going to check during the development to discover any possible misconceptions early, or do you want to see only the final result? I'm a bit new to this :)

@rwinch

This comment has been minimized.

Show comment
Hide comment
@rwinch

rwinch Nov 14, 2016

Member

@danekja Thanks for getting started on this and thanks for reaching out!

I think a valuable way to break this up might be to choose one of the annotations and complete it all the way through. For example, provide xsd, the parser, tests, sample, & documentation for redis XML namespace support. When you have a complete namespace setup, you can submit a PR for that and I will review.

Once you get one of the namespaces done, you can submit additional PRs for the other namespacses.

In terms of what order to provide the XML namespace, I would prefer Redis first as it is the most commonly used. However, you are free to prioritize as you see fit since you are the one spending the time on this.

Member

rwinch commented Nov 14, 2016

@danekja Thanks for getting started on this and thanks for reaching out!

I think a valuable way to break this up might be to choose one of the annotations and complete it all the way through. For example, provide xsd, the parser, tests, sample, & documentation for redis XML namespace support. When you have a complete namespace setup, you can submit a PR for that and I will review.

Once you get one of the namespaces done, you can submit additional PRs for the other namespacses.

In terms of what order to provide the XML namespace, I would prefer Redis first as it is the most commonly used. However, you are free to prioritize as you see fit since you are the one spending the time on this.

@danekja

This comment has been minimized.

Show comment
Hide comment
@danekja

danekja May 16, 2017

Hello, after a long time. Just letting you know I haven't forgotten the task. I was taken out of order due to some health issues for the last few months. But Im alright finally, and after spending quite a few hours on figuring out how the Spring XML configuration parser works, I dont intend to give up :).

danekja commented May 16, 2017

Hello, after a long time. Just letting you know I haven't forgotten the task. I was taken out of order due to some health issues for the last few months. But Im alright finally, and after spending quite a few hours on figuring out how the Spring XML configuration parser works, I dont intend to give up :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment