New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing embedded redis server #121

Closed
dave-r12 opened this Issue Jan 23, 2015 · 8 comments

Comments

Projects
None yet
6 participants
@dave-r12

dave-r12 commented Jan 23, 2015

While configuring one of our apps to use spring-session, I noticed in the samples directory there was a class for creating an embedded redis server (https://github.com/spring-projects/spring-session/blob/master/samples/httpsession/src/main/java/sample/EmbeddedRedisConfiguration.java). I was thinking in our dev environment, we would use this approach.

I copy/pasted the sample for now, but thought this might be helpful in general to others using spring-session.

@xenoterracide

This comment has been minimized.

xenoterracide commented Jan 24, 2015

agreed, this is probably something done in a starter? this class is mentioned in the documentation like it's something you don't write... then for a starter app you could either just add the @EnableRedisHttpSession
and it would enable this for you unless another config provided. Also I was going to file a bug saying the docs don't mention what this is and it's not on the classpath.

@rwinch

This comment has been minimized.

Member

rwinch commented Jan 26, 2015

I do think that providing an embedded Redis solution would be very useful. However, I'm thinking it may be better to do this in Spring Data Redis since it is generally more applicable than Spring Session.

Thoughts @olivergierke ?

@domdorn

This comment has been minimized.

Contributor

domdorn commented Feb 24, 2015

I think that's fixed.

@rwinch

This comment has been minimized.

Member

rwinch commented Feb 24, 2015

@odrotbohm

This comment has been minimized.

Member

odrotbohm commented Feb 24, 2015

For Redis, @thomasdarimont should be able to give more insight.

@thomasdarimont

This comment has been minimized.

thomasdarimont commented Feb 24, 2015

We already looked at this before but at that time the used Redis version was pretty old. Looks better now, I filed: https://jira.spring.io/browse/DATAREDIS-376 and kstyrc/embedded-redis#30

@rwinch

This comment has been minimized.

Member

rwinch commented Apr 9, 2015

@thomasdarimont Thanks for the response. Do you consider kstyrc/embedded-redis#30 a show stopper for including support in Spring Data Redis? I think we could enhance the Spring Data support to use a specific version later on. Thoughts?

@rwinch

This comment has been minimized.

Member

rwinch commented Jul 24, 2015

Thanks for the request. I would really have liked to supported this feature. Unfortunately supporting embedded Redis seems quite impractical at this point. The problems are many (#247 #232 #216 #150 kstyrc/embedded-redis/issues/40 etc) . In summary:

  • We cannot provide binaries for Linux distributions that will work across the board (#247)
  • Windows support is still broken

For these reasons, we are no longer supporting running embedded redis. Since the jar was never published (and just in the samples) this is not a passivity concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment