Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented crawler manager similar to tomcat crawler valve #333

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Thilak-T
Copy link

commented Jan 9, 2016

As documented in the issue #147, we were using tomcat's crawler valve. So implemented for spring-session based on tomcat's valve implementation.

public class CrawlerManagerSessionStrategyWrapper implements MultiHttpSessionStrategy {
private static final Log log = LogFactory.getLog(CrawlerManagerSessionStrategyWrapper.class);

private HttpSessionStrategy delegate;

This comment has been minimized.

Copy link
@martin-g
private HttpSessionStrategy delegate;

private final Map<String,String> clientIpSessionId =
new ConcurrentHashMap<String,String>();

This comment has been minimized.

Copy link
@martin-g

martin-g Jan 10, 2016

Is there a need for concurrency in these maps?
If YES, then why not use ConcurrentMap as a type and use #putIfAbsent() instead of #put().

This comment has been minimized.

Copy link
@Thilak-T

Thilak-T Jan 11, 2016

Author

ConcurrentMap is used because the map cache could be accessed from multiple threads concurrently. #putIfAbsent() is not used as overwrites are allowed. overwrites are legal if for some reason cache is not purged of old session before creating new session.


private final Map<String,String> clientIpSessionId =
new ConcurrentHashMap<String,String>();
private final Map<String,String> sessionIdClientIp =

This comment has been minimized.

Copy link
@martin-g

martin-g Jan 10, 2016

bad formatting.
there is some more ahead.

@kxlt

This comment has been minimized.

Copy link

commented May 12, 2017

What's blocking the merge?

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jun 6, 2019

@Thilak-T Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jun 6, 2019

@Thilak-T Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jun 7, 2019

@Thilak-T Thank you for signing the Contributor License Agreement!

@Thilak-T Thilak-T force-pushed the Thilak-T:master branch from 2e11256 to 55172e2 Jun 8, 2019

@Thilak-T Thilak-T force-pushed the Thilak-T:master branch from 55172e2 to 661952b Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.