New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring JDBC session cleanup cron #907

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@vpavic
Member

vpavic commented Oct 26, 2017

While we currently do have some configuration support for customizing expired session cleanup cron, this binds directly to specific property and is not exposed using standard configuration facilities (JdbcHttpSessionConfiguration/@EnableJdbcHttpSession). This makes it difficult to expose as application property in Spring Boot.

Customization of cron expression is desirable in scenarios with multiple active nodes, where cleanup should ideally run at different schedule on each node in order to reduce the possibility of deadlock occurrence.

Additionally, since current support is property based, it includes registration of PropertySourcesPlaceholderConfigurer bean in JdbcHttpSessionConfiguration which causes conflicts for some users (see #775).

@rwinch

This comment has been minimized.

Show comment
Hide comment
@rwinch

rwinch Oct 27, 2017

Member

Thanks @vpavic! Can you fix the conflicts and then merge this?

Member

rwinch commented Oct 27, 2017

Thanks @vpavic! Can you fix the conflicts and then merge this?

@vpavic

This comment has been minimized.

Show comment
Hide comment
@vpavic

vpavic Oct 27, 2017

Member

No problem, actually I was just about to address this.

Member

vpavic commented Oct 27, 2017

No problem, actually I was just about to address this.

@vpavic vpavic self-assigned this Oct 27, 2017

@vpavic vpavic merged commit 97698fd into spring-projects:master Oct 27, 2017

2 checks passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vpavic vpavic deleted the vpavic:improve-jdbc-config branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment