Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Changes implemented for SOCIALLI-6 #1

Merged
merged 14 commits into from

2 participants

@robdrysdale

I've implemented SOCIALLI-6 in it's entirety. Any chances of getting changes pulled to main repo as changes are extensive and and enough functionality that linkedin api can be released with facebook api.

@habuma
Owner

Wow, great work! I was hoping to get to some of this myself soon, but I'm also happy to receive this contribution. I'll try to find some time to review it soon (later this week, maybe...possible a bit later) and let you know.

@robdrysdale

OK. You have a 100% implementation of LinkedIn Public API now.

@habuma
Owner

I'm getting ready to merge this, but must request a few changes...

  • Please sync up your code with the latest spring-social-linkedin code. Primarily this will bring your build.gradle up to speed with current dependencies
  • Fix all of the deprecation warnings (mostly pertaining to stuff deprecated in Jackson 1.9.x)
  • CommunicationTemplateTest.sendEmailInvitation() failed for me because of the order of fields in the response. No big deal, but confirm that it works and reorder the expectation if necessary to make it work.
  • In NetworkUpdateOperations, please don't declare methods as "public". That's unnecessary in interfaces.
  • Fix all JavaDoc warnings

Thanks

@robdrysdale

Some messy commits. I'm too used to svn.
Should be everything you requested.

@habuma habuma merged commit db626e5 into spring-projects:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 4, 2011
  1. @robdrysdale
Commits on Nov 15, 2011
  1. @robdrysdale
Commits on Nov 16, 2011
  1. @robdrysdale

    Checking in tests, changed back to https accidently removed for testing

    robdrysdale authored
    and corrected small error. Also upgraded spring-social-core to
    1.0.1.BUILD-SNAPSHOT
  2. @robdrysdale
Commits on Nov 17, 2011
  1. @robdrysdale

    Implemented SOCIALLI-2. This adds full details for a user profile and

    robdrysdale authored
    can retrieve other profiles by id and url with full details if desired.
Commits on Nov 18, 2011
  1. @robdrysdale
Commits on Nov 20, 2011
  1. @robdrysdale
Commits on Nov 21, 2011
  1. @robdrysdale
Commits on Nov 24, 2011
  1. @robdrysdale
Commits on Dec 8, 2011
  1. @robdrysdale

    Changes as requested

    robdrysdale authored
  2. @robdrysdale

    Changes as requested

    robdrysdale authored
  3. @robdrysdale

    Revert "Changes as requested"

    robdrysdale authored
    This reverts commit 3089a76.
  4. @robdrysdale

    Revert "Revert "Changes as requested""

    robdrysdale authored
    This reverts commit 22bf137.
  5. @robdrysdale

    Changes as requested

    robdrysdale authored
Something went wrong with that request. Please try again.