Changes implemented for SOCIALLI-6 #1

Merged
merged 14 commits into from Dec 8, 2011

2 participants

@robdrysdale

I've implemented SOCIALLI-6 in it's entirety. Any chances of getting changes pulled to main repo as changes are extensive and and enough functionality that linkedin api can be released with facebook api.

@habuma
Spring member

Wow, great work! I was hoping to get to some of this myself soon, but I'm also happy to receive this contribution. I'll try to find some time to review it soon (later this week, maybe...possible a bit later) and let you know.

@robdrysdale

OK. You have a 100% implementation of LinkedIn Public API now.

@habuma
Spring member

I'm getting ready to merge this, but must request a few changes...

  • Please sync up your code with the latest spring-social-linkedin code. Primarily this will bring your build.gradle up to speed with current dependencies
  • Fix all of the deprecation warnings (mostly pertaining to stuff deprecated in Jackson 1.9.x)
  • CommunicationTemplateTest.sendEmailInvitation() failed for me because of the order of fields in the response. No big deal, but confirm that it works and reorder the expectation if necessary to make it work.
  • In NetworkUpdateOperations, please don't declare methods as "public". That's unnecessary in interfaces.
  • Fix all JavaDoc warnings

Thanks

@robdrysdale

Some messy commits. I'm too used to svn.
Should be everything you requested.

@habuma habuma merged commit db626e5 into spring-projects:master Dec 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment