update tweet object to expose retweeted status, profile, and entities #17

Merged
merged 12 commits into from Oct 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

trajar commented Feb 28, 2012

  • Added twitter profile, and original/retweeted status, to tweet object.
  • Added tweet entities (tag, url, media, metions) to tweet object
  • Updated tweet deserializer to handle the above mentioned elements
  • Added proper equals/hashcode to core tweet, profile objects
Contributor

trajar commented Feb 29, 2012

Per commits, I also added proper equals/hashcode to tweet and profile objects, as well as exposing the 'in reply to' user id and screen name tweet attributes.

Are you planning to include this functionality? I am specially interested in the Entities suppport

Contributor

trajar commented Mar 7, 2012

Per https://dev.twitter.com/blog/api-housekeeping, it seems that the entity support with become standard API behavior.

Contributor

trajar commented Sep 9, 2012

It's been six months - any plan on incorporating this enhancement? I'm happy to address any questions/concerns.

Member

habuma commented Sep 27, 2012

I plan to review and, assuming no surprises, merge your change in the next few weeks. Ideally, in time for SpringOne/2GX in mid-October, but seeing as how this is a low priority and I have a TON of other stuff in the queue, I might not get to it until sometime in November.

In the meantime, if you've not done so already, it would be helpful if you sign the contributor agreement at https://support.springsource.com/spring_committer_signup yet. Thanks.

Member

habuma commented Oct 2, 2012

Trajar: Was thinking about merging this change soon...possibly today or tomorrow. Can you confirm that you have signed the contributor agreement?

Contributor

trajar commented Oct 4, 2012

hubuma: My apologies for tardy response. Just signed the contributor agreement. Merge away - let me know if you have any questions.

habuma merged commit a9c7bec into spring-projects:master Oct 4, 2012

Member

habuma commented Oct 4, 2012

Only a few comments to make so far:

  • The code style isn't consistent with the rest of the project's code. Since there's not much to fix, I'll fix it this time, but please try to follow the coding style you see in the rest of the code for consistency's sake.
  • I see no tests for the new entities stuff. I'll add a few basic tests but I'd appreciate it if you could submit a followup pull request with more tests to cover this change.
  • I'm probably going to default the entities stuff to true for now and not make it optional. First, I don't like adding much to the constructor unless it's strictly necessary, but also the entities stuff will be a given in Twitter API 1.1 and since this API binding is moving in that direction soon, we might as well just go ahead and assume it to always be on, even while it's still on the 1.0 API.
Member

habuma commented Oct 4, 2012

FWIW, I've just merged in the changes to fix code style, add some minimal tests, and to default to always fetching entities. I've also extracted the Jackson annotations out of the various entity classes and put them in Jackson mixins, as done in the rest of Spring Social Twitter. I encourage you to review the changes and either fix or let me know if something is out of sorts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment