Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Facebook threads api #3

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

All,

I would like to add an initial implementation for the facebook thread api.

Let me know your feedback on this

Thanks

Member

habuma commented May 5, 2011

Thanks for the contribution. Just a few things to address:

  1. Your threads.json and thread.json test data files don't look right. It has the "tags" field as an array of Strings, when in fact, the actual data coming back from Facebook is an object with a "data" field containing records of tags. Something like this:

        "tags":
        {
            "data":
            [
                {
                    "name":"inbox"
                },
                {
                    "name":"read"
                },
                {
                    "name":"sent"
                },
                {
                    "name":"source:web"
                }
            ]
        },
    

    So although your test passes, it fails to deserialize when I use it to fetch real data.

  2. I might rename FacebookThread to Thread (yeah...it's the same name as java.util.Thread, but the package is different)

  3. Whenever I call getThread(), passing in a known thread ID, there's a deserialization error. That's because https://graph.facebook.com/{thread ID} seems to always return "false". It seems odd to me that FB would return "false" there, but it does (I get the same thing requesting it directly through my web browser). Have you actually seen it return any real thread data?

  4. Real thread data also includes the actual messages, participants, and a few other items. I know this is your first pass, but do you anticipate adding the ability to fetch a thread's messages (which seems like the most valuable thing about a thread). FWIW, I tried fetch a thread's messages with "https://graph.facebook.com/{thread ID}/messages" and got an empty data list back. It kinda makes me wonder if this part of the Graph API isn't fully baked yet (as hinted in the note at the top of http://developers.facebook.com/docs/reference/api/thread/). Have you had any better luck?

Hi Craig !
First of all, let me say that I really appreciate this kind of feedback. As
you may notice, this is the FIRST time that I will commit something on an open
source community and your kindness is very helpful.
I will take in account each point and commit the code once is finished.
Thanks

Folks,

I won't be able to conitnue working on this.

My apologizes for the inconveniences...

@martosoler martosoler closed this Jun 1, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment