Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Signing of GCP JWT without calling the IAM API #286

Closed
mjungsbluth opened this issue Aug 23, 2018 · 2 comments
Closed

Support Signing of GCP JWT without calling the IAM API #286

mjungsbluth opened this issue Aug 23, 2018 · 2 comments
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement

Comments

@mjungsbluth
Copy link
Contributor

If service account credentials are configured (by providing the key file in GOOGLE_APPLICATION_CREDENTIALS) it should be superfluous to call the IAM API to sign the JWT for Vault login.
The private key is already available locally and can be used to sign the JWT directly (saving a network roundtrip).
@mp911de mp911de added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with labels Aug 23, 2018
@mp911de
Copy link
Member

mp911de commented Aug 23, 2018

Happy to receive a pull request.

@mp911de
Copy link
Member

mp911de commented Aug 14, 2019

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@mp911de mp911de closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mp911de @mjungsbluth