Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshape APIs #49

Closed
rwinch opened this issue Jan 31, 2017 · 2 comments
Closed

Reshape APIs #49

rwinch opened this issue Jan 31, 2017 · 2 comments
Assignees
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Jan 31, 2017

Currently the APIs of VaultTemplate and VaultClient look a lot like RestTemplate. If users want to do the REST operations, they already have RestTemplate to do this. It would be nice if the VaultClient APIs reflected the intent rather than the underlying REST semantics.

@mp911de
Copy link
Member

mp911de commented Jan 31, 2017

This change should reshape VaultSession as well, VaultSession continues the approach from VaultClient.

@mp911de
Copy link
Member

mp911de commented Feb 8, 2017

There are two issues in this ticket:

  1. After discussing with @rwinch we found out that Rob wasn't aware of VaultOperations.
  2. Spring Vault defines a RestTemplate-like through VaultClient. It has a huge API surface and is somewhat an abstraction over RestTemplate with little benefit.

I created two PR's to evaluate different approaches (functional VaultClient exposing less API surface, removal of VaultClient).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants