Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the View Rendering Lifecycle under control of Spring Web Flow with complete support for Spring MVC and JSF views [SWF-367] #1218

spring-operator opened this issue Aug 13, 2007 · 1 comment


Copy link

spring-operator commented Aug 13, 2007

Keith Donald opened SWF-367 and commented

Currently, Spring Web Flow returns logical "view selections" which calling systems use to issue appropriate responses. The advantage of this is it keeps SWF decoupled from the complexity of view rendering. The problem with this is it leads to a good deal of adapter-specific if/else statements (e.g. in MVC, Struts, and JSF) to issue the right response, and it makes it difficult to attach custom flow execution behavior, such as issuing resource cleanup callbacks, to the view rendering lifecycle in a consistent manner.

A good example of a current problem is with Hibernate flow-managed persistence, the session cannot be disconnected before view rendering. Since SWF does not control view rendering, a custom HandlerInterceptor is needed to issue the disconnect callback. This complicates things as a. the handler doesn't have a direct reference to the session and b. its MVC specific -- similiar handlers must exist for the other view technologies Spring Web Flow supports.

As SWF continues to add more features and support more view technologies, this problem is going to get worse. We should investigate putting the view rendering lifectycle under the control of Spring Web Flow. This means SWF view-states would build renderable view selections, capable of actually issuing a suitable response for the given client in the given environment.

Affects: 1.0.4


Issue Links:

2 votes, 3 watchers

Copy link
Contributor Author

Keith Donald commented

View rendering is now under Web Flow's control, with support for JSF and MVC-based views as of M2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant