Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSF ViewFactory hard codes view id to resource mapping behavior which limits flexibilty of ViewHandler viewId->resource mapping logic [SWF-810] #1562

Closed
spring-operator opened this issue Jul 30, 2008 · 1 comment

Comments

@spring-operator
Copy link
Contributor

spring-operator commented Jul 30, 2008

Keith Donald opened SWF-810 and commented

All view id->resource mapping logic should happen inside the ViewHandler.
The logic in resolveViewName of JsfViewFactory should be moved into that layer.
the view id passed to the view handler should simply be:
(String) viewIdExpression.getValue(context);

Alternatively, JsfViewFactory should be configurable with its on view id->resource strategy, but this seems questionable since the ViewHandler has this responsibility.


Issue Links:

1 votes, 2 watchers

@spring-operator
Copy link
Contributor Author

Jeremy Grelle commented

Moved view resource resolution logic into FlowViewHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant