Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method addOmittedFields in XStreamMarshaller should access XStream instance via getter. [SWS-437] #580

Closed
gregturn opened this issue Oct 7, 2008 · 1 comment
Assignees
Milestone

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Oct 7, 2008

Robert Novotny opened SWS-437 and commented

XStreamMarshaller consistently accesses to the XStream instance via getters. However the method addOmittedFields() contains the direct access to the XStream instance.
Original code:
public void addOmittedField(Class type, String fieldName) {
xstream.omitField(type, fieldName);
}

This is inconsistent with the rest of the code in the class and prevents the subclasses of XStreamMarshaller to provide their own implementation of XStream.


Referenced from: commits 725ab96

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 4, 2012

Arjen Poutsma commented

Closing old issues

@gregturn gregturn closed this May 4, 2012
@gregturn gregturn added this to the 1.5.5 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.