Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use OXM from Spring 3 [SWS-567] #689

Closed
gregturn opened this issue Sep 15, 2009 · 9 comments
Closed

Refactor to use OXM from Spring 3 [SWS-567] #689

gregturn opened this issue Sep 15, 2009 · 9 comments
Assignees
Milestone

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Sep 15, 2009

Kenny MacLeod opened SWS-567 and commented

Since the OXM stuff from Spring-WS has now been incorporated into Spring 3, Spring-WS will at some point need to be updated to use the OXM code from the core framework. The OXM code in the core has already moved on, and is newer than that in Spring-WS.

I am currently developing a system using Spring 3 M4 and Spring-WS 1.5.x, and I have to be very careful not to include the OXM code from Spring-WS in the build. When Spring 3 goes final, this will become increasingly problematic as prople try to use them together.

When would you propose making this leap? Perhaps a 1.6 version bump?


Affects: 1.5.8

Issue Links:

  • #714 Drop OXM modules in favor of Spring 3.0
    ("is duplicated by")

1 votes, 1 watchers

@gregturn
Copy link
Member Author

@gregturn gregturn commented Sep 16, 2009

Kenny MacLeod commented

It seems that Spring-WS 1.5.8 will not work with the OXM code from Spring 3. However, some of the OXM clases are present in both Spring 3 and Spring-WS, and yet are slightly different.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Sep 16, 2009

Arjen Poutsma commented

This is planned for Spring-WS 2.0 (previously known as 1.6), where we drop the OXM module in SWS in favor of the one in SPR.

And no: Spring-WS 1.5.x cannot handle the OXM from Spring Core.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Sep 16, 2009

Kenny MacLeod commented

Cool beans. What is the timescale for 2.0? Around the same time as the Spring 3.0 final release?

@gregturn
Copy link
Member Author

@gregturn gregturn commented Sep 16, 2009

Arjen Poutsma commented

Work will start on SWS 2.0 when my work on SPR 3.0 is complete.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Jan 24, 2010

Werner Guttmann commented

{{{
And no: Spring-WS 1.5.x cannot handle the OXM from Spring Core.
}}}

Arjen, can you please elaborate on this subject. Are you saing that - even if we managed our Maven dependencies ourselves and carefully - it is not possible to use Spring 3.0 OXM classes with current (1.5.x) spring-ws code ?

@gregturn
Copy link
Member Author

@gregturn gregturn commented Feb 9, 2010

Arjen Poutsma commented

@Werner

If it works for you, that's good. I have even ran my test suite against SPR's OXM, and it seems to work fine. But it's not 'formally' supported, as I did make some minute changes to the oxm package when it moved to the core.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Feb 9, 2010

Kenny MacLeod commented

I've experienced occasional clashes between Spring 3 OXM and Spring-WS OXM, in particular when using the Spring 3 OXM with MVC, and the appserver happens to pick the Spring-WS OXM classes in preference. It's hard to reproduce, and hard to fix when it does happen, to the point where I try to avoud using OXM from both Spring MVC and Spring-WS in the same application.

The problem, of course, is that the Spring 3 OXM classes have evolved onwards since they were copied from Spring-WS, and if the Spring-WS versions get picked by the classloader, you get "no such method" errors and the like.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Feb 9, 2010

Arjen Poutsma commented

Using SPR's OXM now works for me locally on the SWS 2.0-M1 branch, but we have to wait till SPR 3.0.1 comes out, since I added some required classes there (GenericMarshaller specifically). It should be out later this week.

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 4, 2012

Arjen Poutsma commented

Closing old issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.