Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultConcretePartProvider is not allowing a blank suffix, due to improper assertion [SWS-724] #816

Closed
gregturn opened this issue Aug 11, 2011 · 3 comments
Assignees
Milestone

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Aug 11, 2011

Jason Pyeron opened SWS-724 and commented

The allowance for a blank ("") suffix is esential to be able to maintain compatability w/ legacy or handwritten WSDLs.

should read as:

/** Sets the suffix to append to the port type name to obtain the binding name. */
public void setBindingSuffix(String bindingSuffix) {
    Assert.notNull(bindingSuffix, "'bindingSuffix' must not be null");
    this.bindingSuffix = bindingSuffix;
}

currently as:

public void setBindingSuffix(String bindingSuffix)
{
Assert.hasText(bindingSuffix, "'bindingSuffix' must not be null");
this.bindingSuffix = bindingSuffix;
}

patch forthcomming....


Affects: 2.0.2

Attachments:

Referenced from: commits 7bad577

@gregturn
Copy link
Member Author

@gregturn gregturn commented Aug 11, 2011

Jason Pyeron commented

Permission is given for inclusion or any other use.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Oct 6, 2011

Arjen Poutsma commented

Fixed, thanks for the patch!

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 4, 2012

Arjen Poutsma commented

Closing old issues

@gregturn gregturn closed this May 4, 2012
@gregturn gregturn added this to the 2.0.3 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.