Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature validation fails when using SAML token. [SWS-794] #876

Closed
gregturn opened this issue Aug 24, 2012 · 0 comments
Closed

Signature validation fails when using SAML token. [SWS-794] #876

gregturn opened this issue Aug 24, 2012 · 0 comments

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Aug 24, 2012

jaminh opened SWS-794 and commented

Validation of SAML assertions results in an error in the verifyCertificateTrust() method because this method assumes that signatures are always signed by an X509 certificate. The SAML spec gives an example of a signature that uses the SAML assertion to sign the signature in section 3.5.1.4 Example V2.0 from http://docs.oasis-open.org/wss/v1.1/wss-v1.1-spec-os-SAMLTokenProfile.pdf. After checking "if (actionResult != null)" the type of token(X509, public key, or SAML) used for the signature should be determined and trust should be verified accordingly. The name of the method should probably be changed to since it would be verifying trust on more than just certificates.


Affects: 2.1 GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.