Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleNamespaceContext.removeBinding() does not clean up all references [SWS-819] #899

Closed
gregturn opened this issue Dec 6, 2012 · 3 comments
Assignees
Milestone

Comments

@gregturn
Copy link
Member

gregturn commented Dec 6, 2012

Timo Thomas opened SWS-819 and commented

In SimpleNamespaceContext.removeBinding() the first line should be changed to

String namespaceUri = prefixToNamespaceUri.remove(prefix);

Otherwise the internal map prefixToNamespaceUri still contains the prefix, and hasBinding(String prefix) behaves incorrectly.

This is error is critical, as under certain circumstances XML schema validation fails. If necessary I can provide an example.


Affects: 1.5.9, 2.1.2

Referenced from: commits 041229b, 88b4625

@gregturn
Copy link
Member Author

gregturn commented Dec 7, 2012

Arjen Poutsma commented

Fixed! Thanks for spotting this.

@gregturn
Copy link
Member Author

gregturn commented Dec 9, 2012

Timo Thomas commented

Your welcome. Took me a whole day to track this down. Didn't expect an error at this level, quite surprising that this one could live for so long.

Please also fix for 1.5.10 as this is the version we're currently using. Thanks.

@gregturn
Copy link
Member Author

Arjen Poutsma commented

I've fixed this in the 1.5 branch in SVN, but I am afraid there won't be a 1.5.11 that contains it, as it is not supported anymore.

@gregturn gregturn added this to the 2.1.3 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants