Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AxiomHandler doesn't cleanup prefix mapping between siblings [SWS-895] #973

Closed
gregturn opened this issue Apr 9, 2015 · 7 comments
Closed

AxiomHandler doesn't cleanup prefix mapping between siblings [SWS-895] #973

gregturn opened this issue Apr 9, 2015 · 7 comments
Assignees
Milestone

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Apr 9, 2015

Tommy Winther opened SWS-895 and commented

AxiomHandler must cleanup the prefix mapping created in startPrefixMapping(..).
endPrefixMapping(..) should remove the mapped prefix to avoid later siblings getting previous siblings namespace definitions.

In worst case if the later sibling doesn't define any namespaces (when covered by the parent element) it would get namespace definitions for the previous sibling.


Affects: 2.2.0.RELEASE

Attachments:

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 17, 2015

Greg Turnquist commented

@Tommy

Can you either craft a test case, or supply me with an XML example that illustrates this issue? We aren't going to submit a patch without proof of it solving a problem.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Tommy Winther commented

Hi Greg,

I've attached a test case that fails without the patch in AxiomHandler.

Br.
Tommy

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Greg Turnquist commented

Perfect.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Greg Turnquist commented

Looks great! Have you signed the Spring CLA form? If not, please see https://support.springsource.com/spring_committer_signup

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Tommy Winther commented

Sounds great. I have signed the Spring CLA just now.

Do you have a ballpark estimate when the fix is included in a release?
No rush though, I have patched it locally.

Thanks,
Tommy

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Greg Turnquist commented

Fixed via b8e4b80

@gregturn
Copy link
Member Author

@gregturn gregturn commented Apr 20, 2015

Greg Turnquist commented

I'm not sure when the next release will come out. Spring WS moves pretty slowly these days.

@gregturn gregturn closed this Dec 15, 2015
@gregturn gregturn added this to the 2.2.3 milestone Sep 22, 2020
@gregturn gregturn self-assigned this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant