New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWS-924 Mime header : Manage multiple keys with different values #42

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@pierre-leger
Contributor

pierre-leger commented Nov 1, 2015

Correction for multiple keys with different values in HTTP Response.
Before, in response of mimeheader:

  • cookie: value2
  • cookie: value2
    Now :
  • cookie: value1
  • cookie: value2

To do this:

Issue: SWS-924

I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.

else {
Set<String> tokens = StringUtils.commaDelimitedListToSet(headerField);
return tokens.iterator();
Map<String, List<String>> mapHeader = connection.getHeaderFields();

This comment has been minimized.

@poutsma

poutsma Nov 2, 2015

Contributor

This part of the patch looks fine and can be merged, with the small correction mentioned below.

@poutsma

poutsma Nov 2, 2015

Contributor

This part of the patch looks fine and can be merged, with the small correction mentioned below.

SWS-924 Mime header : Manage multiple keys with different values
Correction for multiple keys with different values in HTTP Response.
Before, in response of mimeheader:
 - cookie: value2
 - cookie: value2
Now :
 - cookie: value1
 - cookie: value2

Issue: SWS-924
@pierre-leger

This comment has been minimized.

Show comment
Hide comment
@pierre-leger

pierre-leger Nov 2, 2015

Contributor

@poutsma updated.

Thanks

Contributor

pierre-leger commented Nov 2, 2015

@poutsma updated.

Thanks

@poutsma

This comment has been minimized.

Show comment
Hide comment
@poutsma

poutsma Nov 2, 2015

Contributor

Ok. His updated version looks fine at first glance.

Arjen

Sent from my iPhone

On 02 Nov 2015, at 17:28, pierre-leger notifications@github.com wrote:

@poutsma updated.

Thanks


Reply to this email directly or view it on GitHub.

Contributor

poutsma commented Nov 2, 2015

Ok. His updated version looks fine at first glance.

Arjen

Sent from my iPhone

On 02 Nov 2015, at 17:28, pierre-leger notifications@github.com wrote:

@poutsma updated.

Thanks


Reply to this email directly or view it on GitHub.

@gregturn

This comment has been minimized.

Show comment
Hide comment
@gregturn

gregturn Nov 2, 2015

Member

Thanks. I'll take it from here.

Member

gregturn commented Nov 2, 2015

Thanks. I'll take it from here.

@gregturn

This comment has been minimized.

Show comment
Hide comment
@gregturn

gregturn Nov 2, 2015

Member

Resolved via 842bace

Member

gregturn commented Nov 2, 2015

Resolved via 842bace

@gregturn gregturn closed this Nov 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment