Enable streaming incoming responses when chunking is enabled (SWS-707) #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes AbstractHttpSenderConnection so that in the case there is no Content-Length header (i.e. chunking is enabled), it no longer reads the entire response into memory to determine whether it is empty or not.
Contributor
|
Looks pretty cool! Is it possible to fashion a unit test to verify this? I imagine mocking would be the best course of action. |
Contributor
Author
|
I've added a regression test. |
Contributor
|
Resolved via cba6791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes AbstractHttpSenderConnection so that in the case there is no
Content-Length header (i.e. chunking is enabled), it no longer reads the
entire response into memory to determine whether it is empty or not.