Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XD-3492 - Add Header-Enricher #1780

Closed
wants to merge 2 commits into from
Closed

Conversation

@dturanski
Copy link
Member

dturanski commented Sep 28, 2015

No description provided.

RandomConfigurationSupport randomConfigSupport = new RandomConfigurationSupport();
application = new SingleNodeApplication().run();
SingleNodeIntegrationTestSupport singleNodeIntegrationTestSupport = new SingleNodeIntegrationTestSupport(
application);

This comment has been minimized.

Copy link
@garyrussell

garyrussell Sep 28, 2015

Member

These variables are not used (randomConfigSupport and singleNodeIntegrationTestSupport) and the tests run ok without them - is there some magic they provide that I am not aware of? Or, can I just remove them?

This comment has been minimized.

Copy link
@dturanski

dturanski Sep 29, 2015

Author Member

they can be removed

This comment has been minimized.

Copy link
@garyrussell

garyrussell Sep 29, 2015

Member

Confused - the comment says it starts the app on random ports - how does that happen without RandomConfigurationSupport.

Also, don't we need an AfterClass with application.close() ??

@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Sep 29, 2015

Merged as 0966eb3 after renaming tests and stopping the singlenode app in @AfterClass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.