XD-1104: Add tests for jdbc sink module and fix bugs #621

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@ericbottard
Member

Worked with @fbiville to add some tests to jdbc module. Discovered some bugs along the way.

Not sure what to do about XD-1162 though (is the problem the fact that we can't support a json map where the keys actually contain an underscore (which is legitimate IMO, but not sure we understand the jira correctly))

@trisberg
Member
trisberg commented Mar 4, 2014

The problem with XD-1162 is that we can't use JSON like {"id": 12, "first_name": "Sven"} since first_name ends up pulling null using firstName when we convert the data values - we should simply check if there is a "first_name" value in the data already - sent a PR to your PR branch with this fix

Otherwise LGTM

@trisberg trisberg self-assigned this Mar 4, 2014
@trisberg
Member
trisberg commented Mar 4, 2014

maybe we can add an additional test for the under_score column

@ericbottard
Member

@trisberg There is one

@trisberg
Member
trisberg commented Mar 4, 2014

Merged with fix for XD-1162

@trisberg trisberg closed this Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment