Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for injection Annotations #198

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gayanper
Copy link
Contributor

commented Feb 9, 2019

Change-Id: I6e35104c9d254a818aa22c1ee679d43c2456d4a2
Signed-off-by: gayanper gayanper@gmail.com

Add support for injection Annotations
Change-Id: I6e35104c9d254a818aa22c1ee679d43c2456d4a2
Signed-off-by: gayanper <gayanper@gmail.com>
@gayanper

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

PR which adds support for mostly used injection annotations.

@martinlippert

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Great that you found the time to work on this, much appreciated. Before we can merge the PR, I would need to have a bunch of automated tests for this new symbol provider, as we have for the other symbol providers. That usually involves creating a test project with some sample sources included and writing the unit tests for that, maybe similar to the SpringIndexerBeansTest (but there are others, too).

@gayanper

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

Sure i will work on it. What do you think about the @= prefix?

@martinlippert

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

The prefix in general sounds fine to me, but I always need to play around with early prototypes and see the things in action to really be able to make up my mind about them. But changing that prefix in the future (if necessary) is not a big deal, maybe you should extract that into a constant to make it even easier.

@kdvolder kdvolder force-pushed the spring-projects:master branch from 4661e19 to a247958 May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.