Skip to content
Permalink
Browse files

update pr-downloader: better error handling / fix exit code not set o…

…n error
  • Loading branch information
abma committed Mar 14, 2020
1 parent 8b22ceb commit a942be9adb87a810368b98ef63a26caf24c062cb
Showing with 1 addition and 1 deletion.
  1. +1 −1 tools/pr-downloader

8 comments on commit a942be9

@domenkozar

This comment has been minimized.

Copy link

@domenkozar domenkozar replied Mar 20, 2020

Is there any chance to make an official release?

@gajop

This comment has been minimized.

Copy link
Member

@gajop gajop replied Mar 20, 2020

You can find builds here: https://springrts.com/dl/buildbot/default/

@domenkozar

This comment has been minimized.

Copy link

@domenkozar domenkozar replied Mar 20, 2020

No source :(

@gajop

This comment has been minimized.

Copy link
Member

@gajop gajop replied Mar 21, 2020

You have the source in this repo. I'm not sure what else you want?

@domenkozar

This comment has been minimized.

Copy link

@domenkozar domenkozar replied Mar 21, 2020

I'm trying to build 104.0.1-1466-g9ee29da maintenance from source so that it would sync.

I expected that hash to be a git commit, so I don't know which commit to take from this repo to match.

Further, just putting correct VERSION file is not enough for springlobby to report synced, I hope I just need to find correct commit.

See NixOS/nixpkgs@a64f618

@abma

This comment has been minimized.

Copy link
Member Author

@abma abma replied Mar 21, 2020

i don't know how to create nixpkgs, but it seems the package is wrong:

from https://nixos.org/nixpkgs/manual/#chap-pkgs-fetchers

"rev in this case can be full the git commit id (SHA1 hash) or a tag name like refs/tags/v1.0"

to get the correct commit id, select the maintenance branch, search for the short hash "9ee29da" on this page

https://github.com/spring/spring/commits/maintenance

->
9ee29da

i guess, setting rev to this should select the correct version.

The "VERSION" file is created when the git repository can be automaticly detected.

@abma

This comment has been minimized.

@domenkozar

This comment has been minimized.

Copy link

@domenkozar domenkozar replied Mar 21, 2020

Thanks @abma, picking the right commit made it work: NixOS/nixpkgs@1ff9d94

Please sign in to comment.
You can’t perform that action at this time.