Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.springframework.data.domain.Pageable is not handled correctly #203

Closed
kaibra opened this issue Nov 29, 2019 · 1 comment
Closed

org.springframework.data.domain.Pageable is not handled correctly #203

kaibra opened this issue Nov 29, 2019 · 1 comment

Comments

@kaibra
Copy link

@kaibra kaibra commented Nov 29, 2019

Hey again,

by looking at some other cases I saw, that the Pageableclass (org.springframework.data:spring-data-commons) is not yet handled.

When used, there is a registered PageableHandlerMethodArgumentResolver and SortHandlerMethodArgumentResolver which take care of a conversion from Query-Parameters to the Pageable-object.

I added a test in my fork kaibra@ee7f874 , app62_actual.json shows the current behaviour.

Regards,

Kai

@springdoc

This comment has been minimized.

Copy link
Owner

@springdoc springdoc commented Nov 29, 2019

The support for Pageable of spring-data is added since v1.2.11.
The projects that uses spring-data-rest should add this dependency together with the springdoc-openapi-ui dependency, which defines the correct converter:

 <dependency>
            <groupId>org.springdoc</groupId>
            <artifactId>springdoc-openapi-data-rest</artifactId>
            <version>1.2.13</version>
 </dependency>

Could you please test and leave your feedback?

@springdoc springdoc closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.