Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests from the round-trip plugin are being incorrectly rejected #33

Closed
philbooth opened this Issue Jun 5, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@philbooth
Copy link
Collaborator

philbooth commented Jun 5, 2014

Jun  5 04:27:39 rum-data boomcatch[2357]: referer=http://test-www.nature.com/nmstr/about/aims address=127.0.0.1[31.221.90.4] method=GET url=/beacon?rt.start=none&rt.tstart=&rt.bstart=1401956859257&rt.end=1401956859818&v=0.9.1400768954&u=http%3A%2F%2Ftest-www.nature.com%2Fnmstr%2Fabout%2Faims
Jun  5 04:27:39 rum-data boomcatch[2357]: 400 Invalid data

@philbooth philbooth added the bug label Jun 5, 2014

@philbooth

This comment has been minimized.

Copy link
Collaborator Author

philbooth commented Jun 5, 2014

Fixed in cff5e93.

@philbooth philbooth closed this Jun 5, 2014

@philbooth

This comment has been minimized.

Copy link
Collaborator Author

philbooth commented Jul 29, 2014

This "fix" was completely misguided, because I didn't understand how boomerang works at the time. It also sends the beacon on beforeunload which is the cause of the "incomplete" data. My attempts to make use of rt.end in that scenario were completely broken.

Reverted in ebd45d1, proper beforeunload handling to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.