Add host() method to docket #1011
Merged
Conversation
@dilipkrish Tell me if you are OK with this. If OK, please wait that I add unit tests before merging. |
looks good to me |
Also it doesn't seem like using |
Is this ready for merge? Trying to close it out so I can include in 2.3 |
Arf! There is a conflict. I will solve it today. |
Rebase done and unit tests OK --> ready to merge |
dilipkrish
added a commit
that referenced
this pull request
Oct 27, 2015
Add host() method to docket fixes #764
@cbornet done! thanks for being patient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR enables overriding the default host from the Docket.
Fixes #764