New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the examples page with Storybook #163

Closed
thibaudcolas opened this Issue Oct 2, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Oct 2, 2018

At the moment, the examples page is done with a JS bundle using Webpack. It would be nice to use Storybook for this so we can have more variations of the editor to display there.

A good first version would be:

  • Storybook set up on the project
  • One story per editor displayed in the examples page at the moment.
@alvinthen

This comment has been minimized.

Copy link
Contributor

alvinthen commented Oct 2, 2018

This sounds like something I could help, lemme get on it

alvinthen added a commit to alvinthen/draftail that referenced this issue Oct 2, 2018

Add examples into Storybook springload#163
Initial attempt to enable storybook.

TODO
* [ ] Mimic existing webpack config in storybook, to enable analytics, proper SVG loading, chunking, optimization, etc...
* [ ] Build storybook into static app.

alvinthen added a commit to alvinthen/draftail that referenced this issue Oct 4, 2018

Add examples into Storybook springload#163
Initial attempt to enable storybook.

TODO
* [ ] Mimic existing webpack config in storybook, to enable analytics, proper SVG loading, chunking, optimization, etc...
* [ ] Build storybook into static app.
@kamaldlk

This comment has been minimized.

Copy link

kamaldlk commented Oct 14, 2018

I'll do it

@alvinthen alvinthen referenced this issue Oct 26, 2018

Merged

Add examples into Storybook #164

2 of 2 tasks complete

thibaudcolas added a commit that referenced this issue Oct 26, 2018

Add examples into Storybook #163
Initial attempt to enable storybook.

TODO
* [ ] Mimic existing webpack config in storybook, to enable analytics, proper SVG loading, chunking, optimization, etc...
* [ ] Build storybook into static app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment