New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some edge cases on entity selection #168

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@Alotor
Copy link
Contributor

Alotor commented Nov 21, 2018

Hi!

This PR fixes some cases that we've detected in a production application using Draftail.

As you can see some are "null safety" checking. But we've found another issue when the user selected backwards the cursor wasn't right. This caused that when editing some custom entities the user input didn't match the one that we got on the state.

This is my first PR for the project so I hope I didn't forgot anything 馃槃

Thanks!

@thibaudcolas

This comment has been minimized.

Copy link
Collaborator

thibaudcolas commented Nov 21, 2018

Hey @Alotor 馃憢 Thank you for reporting this and attempting a fix.

I think I ran into similar issues in the past, but was never quite able to reproduce them consistently. Could you say more about the scenarios in which you detected these? Detailed reproduction steps / screen recordings would be even more valuable.

@thibaudcolas thibaudcolas added the bug label Nov 21, 2018

@thibaudcolas thibaudcolas added this to the v1.1.0 milestone Nov 21, 2018

@Alotor

This comment has been minimized.

Copy link
Contributor Author

Alotor commented Nov 21, 2018

Sure! I've recorded a GIF. It happens also in the playground online.

In the video you can see that if I do a forward selection and then "remove link" it will work. But when I do backwards even if I do a "remove" It doesn't do anything.

This PR should fix this.

BUG

@thibaudcolas

This comment has been minimized.

Copy link
Collaborator

thibaudcolas commented Nov 21, 2018

馃憣 thank you, that's exactly what I needed. I'll have a look at the code as soon as I can.

@thibaudcolas thibaudcolas force-pushed the kaleidos:fixes_bugs_on_entity_selection branch from ce6e97c to ace3c14 Jan 25, 2019

@thibaudcolas thibaudcolas force-pushed the kaleidos:fixes_bugs_on_entity_selection branch from ace3c14 to 95aa9dc Jan 26, 2019

@thibaudcolas
Copy link
Collaborator

thibaudcolas left a comment

Thank you @Alotor! Took me a while to get back to this, but now it will be part of the next release.

@thibaudcolas thibaudcolas merged commit 636f2ad into springload:master Jan 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@thibaudcolas thibaudcolas referenced this pull request Feb 7, 2019

Merged

Release v1.1.0 #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment