From 15026752fe0ca94d09e182670c9beff9ecbbf500 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Fri, 13 Nov 2020 14:33:27 +0000 Subject: [PATCH 1/6] Keyboard Event Which is Deprecatiated https://caniuse.com/keyboardevent-which Though it's usable, it's been depreciated for a while, so is bad practice to use. --- src/components/AccordionItemButton.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/AccordionItemButton.tsx b/src/components/AccordionItemButton.tsx index 1a7d5022..cbe287a7 100644 --- a/src/components/AccordionItemButton.tsx +++ b/src/components/AccordionItemButton.tsx @@ -22,7 +22,7 @@ const AccordionItemButton = ({ ...rest }: Props) => { const handleKeyPress = (evt: React.KeyboardEvent): void => { - const keyCode = evt.which.toString(); + const keyCode = evt.key; if (keyCode === keycodes.ENTER || keyCode === keycodes.SPACE) { evt.preventDefault(); From 6d60f679313a1ddfa3f6ee103d1ed26924903076 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Fri, 13 Nov 2020 14:35:40 +0000 Subject: [PATCH 2/6] Update keycodes.ts --- src/helpers/keycodes.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/helpers/keycodes.ts b/src/helpers/keycodes.ts index 8e888e79..1f625308 100644 --- a/src/helpers/keycodes.ts +++ b/src/helpers/keycodes.ts @@ -1,12 +1,12 @@ const keycodes = { - DOWN: '40', - END: '35', - ENTER: '13', - HOME: '36', - LEFT: '37', - RIGHT: '39', - SPACE: '32', - UP: '38', + DOWN: 'Down', + END: 'End', + ENTER: 'Enter', + HOME: 'Home', + LEFT: 'ArrowLeft', + RIGHT: 'ArrowRight', + SPACE: 'Space', + UP: 'ArrowUp', }; export default keycodes; From c12144730034173a30b2a6d7c30aff452bfe5a61 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Fri, 13 Nov 2020 14:37:40 +0000 Subject: [PATCH 3/6] Update keycodes.ts --- src/helpers/keycodes.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/helpers/keycodes.ts b/src/helpers/keycodes.ts index 1f625308..2d6f67c4 100644 --- a/src/helpers/keycodes.ts +++ b/src/helpers/keycodes.ts @@ -7,6 +7,7 @@ const keycodes = { RIGHT: 'ArrowRight', SPACE: 'Space', UP: 'ArrowUp', + ESCAPE:'Escape'||'Esc' // ie11 uses Esc instead of Escape. }; export default keycodes; From bf2e69969a18df8e340aecfb22a89b92f9f38410 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Mon, 16 Nov 2020 10:45:52 +0000 Subject: [PATCH 4/6] Update keycodes.ts --- src/helpers/keycodes.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/helpers/keycodes.ts b/src/helpers/keycodes.ts index 2d6f67c4..76312de6 100644 --- a/src/helpers/keycodes.ts +++ b/src/helpers/keycodes.ts @@ -7,7 +7,8 @@ const keycodes = { RIGHT: 'ArrowRight', SPACE: 'Space', UP: 'ArrowUp', - ESCAPE:'Escape'||'Esc' // ie11 uses Esc instead of Escape. + ESCAPE:'Escape', + ESCAPE_IE11:'Esc' // ie11 uses Esc instead of Escape. }; export default keycodes; From 7d1151a9b3638c97a99d3eed3ead488327ac7090 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Wed, 18 Nov 2020 00:13:51 +0000 Subject: [PATCH 5/6] Update keycodes.ts --- src/helpers/keycodes.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/helpers/keycodes.ts b/src/helpers/keycodes.ts index 76312de6..5b4f2a1c 100644 --- a/src/helpers/keycodes.ts +++ b/src/helpers/keycodes.ts @@ -6,9 +6,7 @@ const keycodes = { LEFT: 'ArrowLeft', RIGHT: 'ArrowRight', SPACE: 'Space', - UP: 'ArrowUp', - ESCAPE:'Escape', - ESCAPE_IE11:'Esc' // ie11 uses Esc instead of Escape. -}; + UP: 'ArrowUp' +} export default keycodes; From a6ab758c39fa502dfb7618de565c59ab96ca2e76 Mon Sep 17 00:00:00 2001 From: George W Langham Date: Wed, 18 Nov 2020 00:14:41 +0000 Subject: [PATCH 6/6] add semicolon --- src/helpers/keycodes.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helpers/keycodes.ts b/src/helpers/keycodes.ts index 5b4f2a1c..56c37b6a 100644 --- a/src/helpers/keycodes.ts +++ b/src/helpers/keycodes.ts @@ -7,6 +7,6 @@ const keycodes = { RIGHT: 'ArrowRight', SPACE: 'Space', UP: 'ArrowUp' -} +}; export default keycodes;