Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "No" on TOS dialog causes problem #255

Closed
knorker opened this issue Jul 17, 2014 · 3 comments
Closed

Clicking "No" on TOS dialog causes problem #255

knorker opened this issue Jul 17, 2014 · 3 comments
Labels
bug

Comments

@knorker
Copy link

@knorker knorker commented Jul 17, 2014

Inspired by this post:
http://springrts.com/phpbb/viewtopic.php?f=51&t=32368&p=559771#p559763

Clicking "No" on "Terms of Service"-dialog can cause new user to get stuck in endless circle without chance to re-think choice and accept TOS.
Video, 3 minutes: https://www.youtube.com/watch?v=2VxX88ZiXO
"An error occurred during validation." says youtube. if still nessecary will upload somewhere else later..

  1. Register new account
  2. try to log in
  3. On "Terms of Service: agree yes/no" dialog, clicked: No
  4. Connecting to server was not possible: That is expected, but not communicated to user because the message in chat window talks about "invalid username or password" instead:

[12:52:21] ** Server ** Connecting to server Official server...
[12:52:21] ** Server ** Connected to Official server.
[12:52:21] ** Server ** Invalid username or password
[12:52:21] ** Server ** Verbindung zum Server unterbrochen, Chat geschlossen.

  1. When clicking "Verbinden (Connect)" again, the message just got repeated.
    -> Instead the TOS-dialog should come up again, so that user can rethink his choice.

  2. By clicking "Trennen (Disconnect)" it was possible to get to the TOS-dialog again. (but that is not obvious)

  3. Clicking "No" again made springlobby not react to any input anymore.

  4. After closing SL via taskmanager and restarting, now I did not manage to bring the TOS-dialog again at all.

@abma abma added the bug label Jul 17, 2014
@knorker

This comment has been minimized.

@phillipsjk

This comment has been minimized.

Copy link

@phillipsjk phillipsjk commented Jul 17, 2014

You are prompted again if you close the lobby and open it again.

One issue you may come across is that your password does not appear to be saved until you "agree" to the terms. (You need to re-enter your password every time.)

@abma abma closed this in bfb6b2e Jul 17, 2014
@abma

This comment has been minimized.

Copy link
Member

@abma abma commented Jul 17, 2014

when you like, you can test the dev version: http://springlobby.info/temp/builds/abma/sl_master.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.