Skip to content
This repository
Browse code

Updates CHANGELOG.

  • Loading branch information...
commit 6bf5c1f6faa74addbb76da4f551b348da8be9e69 1 parent bf6a80f
Tyler Keating authored December 05, 2012

Showing 1 changed file with 15 additions and 4 deletions. Show diff stats Hide diff stats

  1. 19  CHANGELOG.md
19  CHANGELOG.md
Source Rendered
@@ -58,18 +58,18 @@ Edge
58 58
 
59 59
 ### BUG FIXES
60 60
 
61  
-* Fixes moderate memory leak in SC.Set.  The way that SC.Set removes objects is 
  61
+* Fixes minor memory leak in SC.Set.  The way that SC.Set removes objects is 
62 62
   to "untrack" the internal index of the object by shrinking its length, but it 
63 63
   never actually removed the object at the last index. The only way that the 
64 64
   object could be freed is if a new object is inserted at the same internal 
65 65
   index, thus replacing it. If the objects were removed in the reverse order 
66 66
   that they were added, every object would still be in the set (until they were 
67 67
   possibly overwritten).
68  
-* Fixes major memory leak with bindings and observers.  Previously, SC.Binding 
  68
+* Fixes moderate memory leak with bindings and observers.  Previously, SC.Binding 
69 69
   objects and observers were never cleaned up even as views and objects were 
70 70
   destroyed which could prevent the views and objects from being garbage collected
71 71
   and prevented the binding objects from being garbage collected.
72  
-* Fixes small memory leak in SC.ObserverSet. Each time that a new observer is 
  72
+* Fixes minor memory leak in SC.ObserverSet. Each time that a new observer is 
73 73
   added to an object the ObserverSet for the object will add a tracking hash for 
74 74
   the target and the method. As more methods are tracked for the target, they 
75 75
   are added and as methods are no longer tracked for the target, they are 
@@ -81,7 +81,18 @@ Edge
81 81
 1.9.1 - BUG FIX RELEASE
82 82
 ----------
83 83
 
84  
-* Unit tests indicating ALL fixes are included.
  84
+* Unit tests verifying ALL fixes are included.
  85
+* Fixes a bug that left childView elements in the DOM when they were rendered as 
  86
+  part of their parent's layer and the child was later removed.
  87
+
  88
+  If childView layers are rendered when the parentView's layer is created, the 
  89
+  `layer` property on the childView will not be cached.  What occurs is that if 
  90
+  the childView is then removed from the parent view without ever having its 
  91
+  `layer` requested, when it comes time to destroy the DOM layer of the 
  92
+  childView, it will try to find it with a `get('layer')`. The bug was that it 
  93
+  only returned a layer if the view has a parent view. However, since the child 
  94
+  was removed from the parent first and then destroyed, it no longer has a 
  95
+  parent view and would not try to find its leftover DOM layer.
85 96
 * Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).  It 
86 97
   was naively using forEach to iterate through the objects while mutating the 
87 98
   array so that the last object could never be constrained.

0 notes on commit 6bf5c1f

Please sign in to comment.
Something went wrong with that request. Please try again.