Permalink
Commits on Jun 26, 2013
  1. Fixes a regression with SC.CollectionView that occurred after a previ…

    …ous fix to remove a view DOM leak. SC.CollectionView previously created a view with the same layerId as the view to be replaced before replacing it, which only worked because of some weird logic external to the CollectionView that used to prevent a view from being able to find its layer if it didn't have a parentView (which was also the cause of a leak because the layer might still exist in the DOM). In any case, having two views use the same layerId at the same time is a bad idea.
    
    So instead we essentially use removeChild().insertBefore() rather than insertBefore().removeChild() (i.e. replaceChild()).
    publickeating committed with publickeating Jan 4, 2013
Commits on Apr 11, 2013
  1. Updates version to 1.9.2.

    publickeating committed Apr 11, 2013
Commits on Apr 3, 2013
  1. Fixes improper binary search used by SC.ManyArray addInverseRecord th…

    …at resulted in an infinite loop. Closes #626.
    publickeating committed Apr 3, 2013
  2. Fixes bug that allowed the context menu to appear regardless of overr…

    …iding contextMenu in a view or setting SC.CONTEXT_MENU_ENABLED or isContextMenuEnabled to false. This makes the context menu event handling behave the same as the key, mouse, etc. event handling. Fixes #549.
    publickeating committed Apr 3, 2013
Commits on Apr 2, 2013
Commits on Apr 1, 2013
  1. Some actions need to be always handle by a TextFieldView when it has …

    …the focus
    
    If a parentView of a TextFieldView handle deleteForward deleteBackward,
    moveLeft, moveRight, selectAll, moveUp or moveDown, the event will not
    be mapped to the TextFieldView.
    nicolasbadia committed with publickeating Nov 6, 2012
  2. If SC.TextFieldView is not a text area, let the next responder handle…

    … the event
    Nicolas BADIA committed with publickeating Sep 17, 2012
  3. Fix SC.TextFieldView to insert a new line when the enter key is press…

    … on a text area
    
    A fix were already there for the SC.InlineTextFieldView class so I copy
    it into the TextFieldView class. I've updated the
    SC.InlineTextFieldView class so that it now call the super class in the
    case where it is a text area.
    
    I've also removed some useless code in the InlineTextFieldView class:
    - A fix in the insertNewline method which is not needed anymore
    - The method fieldValueDidChange which only call the super class
    Nicolas BADIA committed with publickeating Sep 17, 2012
  4. Fixes the hint value for SC.LabelView so that it will appear when the…

    … label has no value and isEditable is true. Includes unit test.
    publickeating committed Apr 1, 2013
Commits on Mar 30, 2013
  1. Creates objects for the overflow menu items rather than modifying the…

    … underlying item, which may have been an original SC.Object based item that we shouldn't dirty. Updates unit tests to use a local icon.
    publickeating committed Mar 30, 2013
  2. Updates VERSION for 1.9.2.

    publickeating committed Mar 30, 2013
  3. Fixes debug images and test iframe.html being included in builds. The…

    …se files (one of which is 2.5MB) would get included into every build, because they were at the wrong path. I removed the apple logo which appears unused in the tests and fixed the directory structure and file references so that 'a_sample_image.jpg' and 'iframe.html' don't get included in production builds.
    
    Note: this is especially a problem if you wanted to create an app manifest based on the contents of the built static directory.  The client would have to download a 2.5MB debug image that is never used.
    publickeating committed with publickeating Jan 22, 2013
  4. Fixed unit tests.

    krotscheck committed with publickeating Jan 14, 2013
  5. Corrected spelling of "win" in unit tests.Fixed browser unit test to

    throw errors when an expected property is simply not set.
    krotscheck committed with publickeating Jan 14, 2013
  6. add word wrap

    With Chrome on windows 8, window.ontouchstart === null and without this
    fix, the click events doesn't work.
    nicolasbadia committed with publickeating Jan 9, 2013
  7. Add missing un-prefixed border-radius rules

    Related to issue #847
    nicolasbadia committed with publickeating Jan 7, 2013
  8. Fixes regression in IE7 and IE8 which caused XHR requests to fail to …

    …notify. Also fixes unit tests to pass in IE7+.
    publickeating committed Mar 30, 2013
Commits on Jan 3, 2013
  1. Provides backwards compatibility for providing the callback inside of…

    … the options object and adds warnings that only the standard arguments should be used. Fixes #861 for 1.9.2.
    publickeating committed Jan 3, 2013
Commits on Dec 6, 2012
  1. Updates CHANGELOG.

    publickeating committed Dec 6, 2012
Commits on Nov 22, 2012
  1. Fixes a bug that left childView elements in the DOM when they were re…

    …ndered as part of their parent's layer and later removed.
    
    If childView layers are rendered when the parentView's  layer is created, the `layer` property on the childView will not be cached.  What occurs is that if the childView is then removed from the parent view without ever having its `layer` requested, when it comes time to destroy the DOM layer of the childView, it will try to find it with a `get('layer')`.  The bug was that it only returned a layer if the view has a parent view.  However, since the child was removed from the parent first and then destroyed, it no longer has a parent view and would not try to find its leftover DOM layer.
    
    - Includes unit test.
    publickeating committed Nov 22, 2012
Commits on Nov 21, 2012
  1. Updates CHANGELOG.md.

    publickeating committed Nov 21, 2012
  2. Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).

    After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
    publickeating committed Nov 21, 2012
  3. Implicit globals, creating a possible memory leak. Not sure if these …

    …were in fact cause a problem but as I was looking to extend this class those jumped out at me.
    mitchless committed with publickeating Nov 5, 2012
Commits on Oct 29, 2012
  1. Updates the Changelog.

    publickeating committed Oct 29, 2012
  2. Removes duplicate check.

    publickeating committed Oct 29, 2012