Skip to content
Commits on Apr 1, 2014
  1. @publickeating
Commits on Mar 27, 2014
  1. @publickeating
  2. @publickeating

    Fixes exception when hitting the return key on editable collection vi…

    publickeating committed
    …ew with no selection. Refactored the method to prevent attempting to edit invalid item views. Includes unit test.
  3. @publickeating

    Prevents SC.CollectionView.prototype.itemViewForContentIndex() from r…

    publickeating committed
    …eturning item views for invalid indexes. It's easy for loops and other code to accidentally retrieve an index not within the collection, which would have previously returned an item view not backed by content and with other invalid attributes. Instead, the method will return null for invalid indexes and in debug mode only will present a warning to help the developer track down the problem. Includes unit tests.
  4. @dcporter

    Updates runtime to remove minor dependencies on jQuery. Moves root jq…

    dcporter committed
    …uery framework dependency from runtime to core_foundation.
Commits on Mar 26, 2014
  1. @jribar @dcporter

    Fix issue with SC.SelectView not updating list of items when items is…

    jribar committed with dcporter
    … set to an empty array. With test
  2. @publickeating

    Ensures that the format property of SC.DateField updates when formatD…

    publickeating committed
    …ateTime, formatDate or formatTime change. Includes unit test.
Commits on Mar 24, 2014
  1. @dcporter
Commits on Mar 21, 2014
  1. @publickeating

    Adds debug-mode only toString method for SC.ChildArray to give a bit …

    publickeating committed
    …more information akin to SC.ManyArray & SC.RecordArray.
  2. @publickeating

    Refactors SC.ChildArray to:

    publickeating committed
     - remove range observers on the underlying data hash array
     - tackle the difficult issue of separating removed nested records from the array and the parent record (fixes failing unit tests)
     - optimizes SC.ChildArray to not be as noisy
     - clean up a bunch of incorrect documentation copied and pasted over from SC.ManyArray
     - hopefully, makes the code more understandable and easy-to-follow
  3. @publickeating
  4. @publickeating

    Tidies up SC.ChildrenAttribute and removes the call override which do…

    publickeating committed
    …esn't appear to add any value.
  5. @publickeating

    Adds tests highlighting the intricacies of how nested records change …

    publickeating committed
    …depending on when and how they're accessed.
  6. @publickeating
  7. @publickeating

    Adds tests showing problems working with SC.ChildArray items. Adds te…

    publickeating committed
    …st for deep property (more than one level nested) updates.
Commits on Mar 20, 2014
  1. @dcporter
Commits on Mar 18, 2014
  1. @publickeating

    Fixes the debug only SC.PickerPane message. This helps developers avo…

    publickeating committed
    …id confusion if accidentally calling append instead of popup on a picker pane.
  2. @publickeating

    Fixes bug that doesn't clear nested records from a store reset (fixes…

    publickeating committed
    … failing unit test in previous commit).
  3. @publickeating
Commits on Mar 14, 2014
  1. @publickeating

    JSHint cleanup.

    publickeating committed
  2. @publickeating

    Prevents SC.CollectionView from pooling views that don't have a layou…

    publickeating committed
    …t (i.e. static views). Fixes failing unit test.
  3. @publickeating

    Removes forcing the prototype layout onto all child views which is re…

    publickeating committed
    …dundant and prevents child views from having their own layout.
  4. @publickeating
  5. @dcporter
  6. @dcporter

    Adds an escapeForCSS method to SC.String.

    Greg Fairbanks committed with dcporter
    The '.' and ':' characters are valid in HTML ids, but cannot be used in
    a jQuery selector without being escaped. I added a method to escape a
    string for use as a jQuery selector.
  7. @dcporter
Commits on Mar 13, 2014
  1. @publickeating

    Revert "Swaps out @jlaxson's SC.SegmentedView#shouldAutoResize for @p…

    publickeating committed
    …ublickeating's suggestion that the behavior be mediated by setting shouldHandleOverflow to NO. (There is currently no way to prevent resizing in a static-width segmented view with shouldHandleOverflow: NO; if that's a need, it shouldn't be hard to implement.)"
    
    This reverts commit 3f91289.
Commits on Mar 11, 2014
  1. @dcporter

    Fixes a number of issues with SC.SplitView:

    dcporter committed
    - Adds layoutDirection property and class-name to SplitDividerView. Hooks up propagation from parent SplitView.
    - Fixes bug where SplitView's class-names would update incorrectly when layoutDirection changed. (Previous class was not being removed.)
    - Fixes CSS bug where selector hierarchies were insufficiently specific, causing a misapplication of styles in nested SplitViews with different layoutDirections.
    - Includes unit tests.
Commits on Mar 7, 2014
  1. @dcporter

    Have SC.ScrollView#scrollToRect prefer the top/left of the rect.

    Greg Fairbanks committed with dcporter
    Previously, the top/left side would be scrolled into view first, then the
    bottom/right side. This resulted in the bottom right being in view if the
    rect was larger than the viewport.
    
    Now scroll the bottom/right first, so the top/left is in view in this case.
Commits on Mar 5, 2014
  1. @dcporter
Commits on Mar 3, 2014
  1. @publickeating

    Adds some debug-mode only developer support to prevent the easy mista…

    publickeating committed
    …ke of using .append(anchor) with a picker pane instead of .popup(anchor).
  2. @publickeating
  3. @publickeating
  4. @publickeating

    Adds much more descriptive documentation for configuring SC.PickerPan…

    publickeating committed
    …es including the use of new constants SC.POSITION_RIGHT, SC.POSITION_LEFT, SC.POSITION_TOP & SC.POSITION_BOTTOM to make the values of preferMatrix more clear.
Commits on Mar 1, 2014
  1. @publickeating

    Merge pull request #1185 from sproutcore/team/fairbanksg/collection-v…

    publickeating committed
    …iew-layer-id
    
    Use CollectionView's layerId rather than guid in contentIndexForLayerId.
Something went wrong with that request. Please try again.