Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SC.SliderView should accept an orientation #765

Open
tim-evans opened this Issue Apr 6, 2012 · 7 comments

Comments

Projects
None yet
4 participants
Member

tim-evans commented Apr 6, 2012

We should be able to render vertical sliders.

The API should look like:

MyApp.SliderView = SC.SliderView.design({
  orientation: VERTICAL_ORIENTATION
});
Member

workmanw commented Apr 7, 2012

+1

Since the API doesn't currently exist, I'm labeling this a feature and slating it for SC 1.9. Sound good?

Member

tim-evans commented Apr 7, 2012

Sounds good to me!

Wesley Workman reply@reply.github.com wrote:

+1

Since the API doesn't currently exist, I'm labeling this a feature and slating it for SC 1.9. Sound good?


Reply to this email directly or view it on GitHub:
#765 (comment)

Owner

publickeating commented Apr 9, 2012

+1

I have written such code and cleaned up the class a little, I can submit it as a pull request unless someone beats me to it.

Member

tim-evans commented Apr 9, 2012

@publickeating I might beat you ;)

Member

tim-evans commented Apr 9, 2012

I'd welcome a code review if I beat you though.

Owner

publickeating commented Apr 12, 2012

The reason I can’t submit it directly is because I wrote it on top of TemplateView as an experiment. You can check it out here: https://gist.github.com/2364444

It has orientation AND direction support (left-to-right or right-to-left). I did the same for ProgressView and it’s even simpler, but I’ve since decided that building a competing set of controls is not a good idea and that TemplateView is doing more harm than good for us and so it would be better to focus on revamping Desktop. In reality we need to take an inventory of all the views and controls and map out what is going to be in 2.0 and what gaps and overlaps there are in orientation, direction or other shared attributes.

dcporter added a commit that referenced this issue Jun 25, 2014

Owner

dcporter commented Jun 25, 2014

I've taken a crack at this in team/dcporter/verticalslider. It works and it looks good in BaseTheme, but I can't figure out the vertical slider slicing in Ace. Could someone take a closer look at this and see if you can crack it? Feel free to push to my branch if you've got permission and a solution, otherwise please link to your commit and I'll cherry-pick it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment