Failing unit test in SelectionSupport #870

Closed
publickeating opened this Issue Nov 21, 2012 · 0 comments

Projects

None yet

1 participant

@publickeating
Member

"Test SC.SelectionSupport mixin with ArrayController. module: SC.ArrayController(SC.SelectionSupport) selection remains while content is replaced" has two failing unit tests on master.

@publickeating publickeating added a commit that closed this issue Nov 21, 2012
@publickeating publickeating Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).
After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
74bf449
@publickeating publickeating added a commit that referenced this issue Nov 21, 2012
@publickeating publickeating Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).
After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
43f539a
@nicolasbadia nicolasbadia added a commit to nicolasbadia/sproutcore that referenced this issue Dec 13, 2012
@publickeating @nicolasbadia publickeating + nicolasbadia Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).
After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
5a5304f
@mitchless mitchless added a commit to mitchless/sproutcore that referenced this issue May 31, 2013
@publickeating @mitchless publickeating + mitchless Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).
After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
fe4126f
@fairbanksg fairbanksg pushed a commit to FernCreek/sproutcore that referenced this issue Jun 4, 2013
@publickeating publickeating + Greg Fairbanks Fixes improper implementation of SC.SelectionSet:constrain (fixes #870).
After cleaning up a memory leak in SC.Set, it was discovered that the constrain method of SC.SelectionSet doesn't work properly.  It was naively using forEach to iterate through the objects while mutating the array so that the last object would never be constrained.  Includes unit test.
570b102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment