Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes useless uses of the slice mixin #1404

Closed
wants to merge 1 commit into from

Conversation

nicolasbadia
Copy link
Member

No description provided.

@mauritslamers
Copy link
Member

I am not sure this is the right approach. The advantage of using @include slice is that the BT currently converts it into base64 encoded urls. If sc_static is used, there is no way of embedding the icons. Moreover, it might be clever to take a look at how we could get rid of these files by using FontAwesome.

@nicolasbadia
Copy link
Member Author

I believe replacing this images by FontAwesome icons is indeed the way to go.
I also think we should add an sc method to the BT to specifically convert images into base64 encode urls. We should also deprecate slice as you suggested on IRC as it doesn't really makes sense anymore in the modern web.

@nicolasbadia nicolasbadia deleted the team/nicolasbadia/slice branch February 24, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants