New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors SC.MenuPane to use SC.ListView internally #1443
base: master
Are you sure you want to change the base?
Conversation
a9fe6e6
to
afe8c84
Compare
I disagree with removing SC.ContentDisplay. It might not be used here, but it is very useful to have in many other circumstances. |
33b7d91
to
7630c79
Compare
I reverted the SC.ContentDisplay removal and added support for |
32125eb
to
e6bbb5e
Compare
I updated the last commit with the suggested adjustements. |
A few things: The commit 7f7e730 turns out to be responsible for the failing tests (https://travis-ci.org/sproutcore/sproutcore/builds/350716397#L1740), as a change in the title of an item in the items is no longer picked up as there is no mechanism for it. Also I think the commit history is a bit messy, as it removes and then re-adds functionality. It also includes changes to for example the designer framework, which is more or less dead weight IIRC. There seems to be a contradiction in the description up, specifically where you mention that you remove the localization support but in the resulting code the localize setting on the view is still there. Is the change that you removed the option to automatically localize all the menu items? |
045da60
to
2463b05
Compare
Nasty because if unexpectedly update the value when the items changes.
Also fixes a memory leak on the radio view because the observers were never destroyed
… mouse event listeners
3227d2f
to
d2b38f6
Compare
SC.MenuPane no use SC.ListView internally in order to be able to display huge lists of items.